Keyboard Shortcuts
Likes
- Jmriusers
- Messages
Search
Locked
Re: Clarifying expection
Thanks for your suggests. I will continue to use the group. Phil On Sat, Feb 8, 2020 at 6:12 PM Steve_G <RailRodder@...> wrote: Hi Phil |
|||||
Locked
Re: Vanishing Roster
I have noticed what seems to be this same symptom a couple of times as well. A simple restart of JMRI and all is well, the roster "returns". No rebuild roster needed, the roster.xml file is unchanged (it's in DropBox, so I see change history).
I enabled roster debug a while back, but the messages were identical for the failed attempt as for the successful attempt. In both cases, the "readFile sees xx children" and the subsequent "Add entry..." lines are as expected. Tried several more times and could not get the failure to repeat. |
|||||
(sorry for polluting the thread)
I couldn't help but opened an issue with JMRI repository, to save a bit of traffic here. Dave, if you will be making a custom build for me, could you please 1) add some logging there to dump the whole 'M' command, and 2) instead of increasing length condition from 5 to 6, just change the 'for' cycle in line 2445 to run until num_bytes-1? Thanks again. Regards Tim |
|||||
Locked
Re: Operations manifest printing
#operationspro
sorry for the late entry but I am having similar problems with my new printer -? ?it prints the manifests but in minuscule fonts.
then printer is an HP 2600 and is the default printer computer is an? Acer running win 10 and the jmri is V4.11 i think. All other devices in the house print fine from above discussion it looks like the quick fix would be to print to a pdf.? Not quite sure how to get this done, As always, thanks for your help Gene |
|||||
Locked
Re: Undefined problem double x over in Panel Pro editor
#paneleditor
¿ªÔÆÌåÓýIt makes no difference which I position the mouse button over I do not in any case get the drag image to move into any of the spaces on the icon panel. No worries, in the middle of the night I woke up with a solution! I just used the turnout function, moved two of each to the panel, rotated one of each 180 degrees, resized them to 75%, and ?placed them so that they look like a double cross over. They are all numbered with the same turnout number so they work in unison ! Done deal, working for me. A rather around the block solution but it works. Thanks for the input, this baby is put to bed! Lol ? Terry Cummins S.E. Michigan ? Sent from for Windows 10 ? From: Dave Sand
Sent: Monday, February 10, 2020 9:38 PM To: [email protected] Subject: Re: [jmriusers] Undefined problem double x over in Panel Pro editor #paneleditor ? Terry, ? Just to be clear, you position the mouse over a turnout name, click and hold the mouse button, move the move over a "undefined" box and release the mouse button? ? What version of JMRI are you running? ? ? Dave Sand ? ? ----- Original message ----- From: mrclassicman <mrclassicman512@...> Subject: Re: [jmriusers] Undefined problem double x over in Panel Pro editor #paneleditor Date: Monday, February 10, 2020 8:19 PM ? Dave, I uploaded a screen shot of the Panel Pro Editor screen open with the "undefined boxes". Sorry I don't know why the screen shot is so fuzzy. Additionally I tried as you suggested moving the names to the boxes and or the icons to the boxes and there is no common dragging the image, as with all of the other placed icons, present. There must be something very simple that I am missing as everything else has worked perfectly! So I am back to looking at this tomorrow. There must be some means for defining the required boxes and it must be deep in the program. The image is has been loaded into the photo section under the heading "Panel Pro Editor X over" -- Terry Cummins S.E. Michigan ? ? -- Terry Cummins S.E. Michigan |
|||||
For the record, here are changes I made to DCC++ BaseStation code for 6 byte packets.
PacketRegister.h:
PacketRegister.cpp: in?RegisterList::loadPacket starting from Line 70: and in?RegisterList::writeTextPacket, starting from Line 203: Sorry I failed to make myself clear regarding sscanf() behavior, certainly it will report correct number of arguments scanned for 2, 3, 4, and 5 cases. What I meant was that it would report nBytes=6 when there are more arguments passed to it than is noted in its format string, and thus RegisterList::writeTextPacket() won't report this as an error. Regards Tim |
|||||
Update, spent a couple of hours late into the night trying everything that was suggested. Nothing seemed to change. Finally decided just to clear everything off and start over this morning. So I deleted the entire program and reinstalled it this morning. I do not know what is different, but the system is working! I have throttle control and I have programmability. thanks for all the help and suggestions, Bruce Mount Airy, Maryland
toggle quoted message
Show quoted text
On Feb 10, 2020, at 8:33 PM, Dave Heap <dgheap@...> wrote: |
|||||
Locked
Re: Undefined problem double x over in Panel Pro editor
#paneleditor
¿ªÔÆÌåÓýIt makes no difference which I position the mouse button over I do not in any case get the drag image to move into any of the spaces on the icon panel. No worries, in the middle of the night I woke up with a solution! I just used the turnout function, moved two of each to the panel, rotated one of each 180 degrees, resized them to 75%, and ?placed them so that they look like a double cross over. They are all numbered with the same turnout number so they work in unison ! Done deal, working for me. A rather around the block solution but it works. Thanks for the input, this baby is put to bed! Lol ? Terry Cummins S.E. Michigan ? Sent from for Windows 10 ? From: Dave Sand
Sent: Monday, February 10, 2020 9:38 PM To: [email protected] Subject: Re: [jmriusers] Undefined problem double x over in Panel Pro editor #paneleditor ? Terry, ? Just to be clear, you position the mouse over a turnout name, click and hold the mouse button, move the move over a "undefined" box and release the mouse button? ? What version of JMRI are you running? ? ? Dave Sand ? ? ----- Original message ----- From: mrclassicman <mrclassicman512@...> Subject: Re: [jmriusers] Undefined problem double x over in Panel Pro editor #paneleditor Date: Monday, February 10, 2020 8:19 PM ? Dave, I uploaded a screen shot of the Panel Pro Editor screen open with the "undefined boxes". Sorry I don't know why the screen shot is so fuzzy. Additionally I tried as you suggested moving the names to the boxes and or the icons to the boxes and there is no common dragging the image, as with all of the other placed icons, present. There must be something very simple that I am missing as everything else has worked perfectly! So I am back to looking at this tomorrow. There must be some means for defining the required boxes and it must be deep in the program. The image is has been loaded into the photo section under the heading "Panel Pro Editor X over" -- Terry Cummins S.E. Michigan ? ? -- Terry Cummins S.E. Michigan |
|||||
Tim, Dave, "By adding debug print of nBytes I learned it is always set to 6, and it is the number of parameters the "%d %x %x %x %x %x"?format
string expects (1 decimal for register number, and 5 hexes for
parameters). It appears sscanf() just ignores the rest of input once it
successfully stuffes all variables in its list." It is very easy to make this code a lot more robust so it catches the 'too many parameters' as an invalid packet. Instead of passing in the actual message, pass in a modified one with a known trailing character (any will do, say 'X'). So in the example the string going in would become: "M 0 1 2 3 4 5 6X" and the scanf string: "%d %x %x %x %x %xX" No difference in result for this message, but if you have that extra input as in "M 0 1 2 3 4 5 6 7 8", (again passed in with the appended 'X' as): "M 0 1 2 3 4 5 6 7 8X" Using scanf with the same "%d %x %x %x %x %xX" now fails, detecting invalid packet, because it cannot match the now required 'X'. It may not be a good moment for this change as you want the smallest possible modification at this point, but it is easy defensive programming that can catch unexpected issues, and could be something to keep in mind for later. Wouter On Tue, 11 Feb 2020 at 09:50, tnt23 <tim.tashpulatov@...> wrote: Dave, |
|||||
¿ªÔÆÌåÓýTim, Next was the well-behaved '<M 0 1 2 3 4 5>' which went through perfectly silent. But you didn't try ?'<M 0 1 2 3>' . I don't think you'll get nBytes=6 when the number of supplied parameters are less than those in the format string and variables). See <> Please set the DCC++ code as per my crossed-in-delivery email. Dave in Australia |
|||||
¿ªÔÆÌåÓýTim, To late at night for me to be thinking code. We want to minimise changes and possible breaking of existing code, JMRI and other. Please change: 1) Documentation at lines 482 ff of SerialCommand.cpp needs extra parameter adding. 2) Change??PacketRegister.cpp, method?writeTextPacket?as below: /////////////////////////////////////////////////////////////////////////////// void RegisterList::writeTextPacket(char *s) volatile{ ?? ? int nReg; ? byte b[7]; ? int nBytes; ? volatile RegisterList *regs; ? ?? ? nBytes=sscanf(s,"%d %x %x %x %x %x %x",&nReg,b,b+1,b+2,b+3,b+4,b+5)-1; ?? ? if(nBytes<2 || nBytes>6){ ? ?// invalid packet ? ? INTERFACE.print("<mInvalid Packet>"); ? ? return; ? } ? ? ? ? ? ? loadPacket(nReg,b,nBytes,0,1); ? ?? } // RegisterList::writeTextPacket() ?? /////////////////////////////////////////////////////////////////////////////// I'll change: Line 2441 of??in the private build to be: ? ?if?(num_bytes?<?2?||?num_bytes?> 6)?return(null); You can then test the result with your DCC++ hardware. Dave in Australia |
|||||
Dave,
Will share the changed pieces tonight once I am at my home computer.
?
That is correct. My experience is based on feeding different variants of 'M' command to DCC++ Base Station via serial console, and watching the result. Started with '<M 0 1>', got '<mInvalid packet>' response in accordance with the (unmodified original) code:
Next was the well-behaved '<M 0 1 2 3 4 5>' which went through perfectly silent. Then I tried '<M 0 1 2 3 4 5 6 7 8'> and did not get error response. By adding debug print of nBytes I learned it is always set to 6, and it is the number of parameters the "%d %x %x %x %x %x"?format string expects (1 decimal for register number, and 5 hexes for parameters). It appears sscanf() just ignores the rest of input once it successfully stuffes all variables in its list. But I believe it is irrelevant at this point. More important is the knowledge that JMRI always passes the packet bytes to the DCC++ including last checksumbyte. I will need to think this over, too. Regards Tim
|
|||||
¿ªÔÆÌåÓýTim, (It is probably worth nothing to note that DCC++ code, as it seems, will not spot extra bytes in 'M' message. The sscanf template used will always try to read up to 5 or 6 parameters, and will always return maximum number, 5 or 6, even if being fed 10 or 15 parameters) That needs updating to scan the extra parameter and load it into the extra element of the array. What does your modified code look like? Please show us. My reading (I'm not a C++ speaker) of the code is that the sscanf ?function returns the number of successful matches*, not the number of parameters. So nBytes returns the actual number of parameters (minus 1 for the register parameter). nBytes is the number of bytes specified to loadPacket? *<> Dave in Australia |
|||||
¿ªÔÆÌåÓýTim, Of these 6 bytes, last checksum byte does not need to be passed to DCC++ as it is calculated internally by DCC++ code when forming the packet. This means that 'M' command should be passing 5 bytes to DCC++, as follows: The problem is that the NmraPacket class in JMRI creates and appends the checksum for every method (packet type) defined. <> We can't change that code without breaking every other system. Packet lengths vary (they are not all 6 bytes). Dropping the last byte of every M command changes the DCC++ specification as far as I can see and would break any non-JMRI software using the DCC++ system. But too late in the day for this sort of thinking... Dave in Australia |
|||||
¿ªÔÆÌåÓýTim, Dave,Agreed, provided the DCC++code is updated as well
Will have to be tomorrow. After dinner here and computers shut down due to storms. Dave in Australia |
|||||
On another thought, though:
Extended Decoder Control Packet address for operations mode programming (clause 485 on page 10 of s-9.2.1) looks like this: {preamble} 10AAAAAA 0 0AAA0AA1 0 (1110CCVV 0 VVVVVVVV 0 DDDDDDDD) 0 EEEEEEEE 1Of these 6 bytes, last checksum byte does not need to be passed to DCC++ as it is calculated internally by DCC++ code when forming the packet. This means that 'M' command should be passing 5 bytes to DCC++, as follows: <M 0 1 2 3 4 5>, where the first 0 after M is Register number and should not count in num_bytes. Is there a way to add parameters debugging output to console or log for the?makeWriteDCCPacketMainMsg?routine? Regards Tim |
|||||
Dave,
This makes me think the DCCppMessage.java is worth updating for 6 byte packets, too :) (It is probably worth nothing to note that DCC++ code, as it seems, will not spot extra bytes in 'M' message. The sscanf template used will always try to read up to 5 or 6 parameters, and will always return maximum number, 5 or 6, even if being fed 10 or 15 parameters) No, I did not checkout JMRI sources as I plain have no idea what to do with them in the first place :) Yet if you could build a test version for me that would be awesome. Thanks a bunch! Regards Tim |
|||||
Locked
Re: Help Setting up JMRI & NCE Power Cab Via USB
Sorry, link omitted.
On 11 Feb 2020, at 3:47 PM, Dave Heap <dgheap@...> wrote:<> Dave in Australia |
|||||
Locked
Re: Help Setting up JMRI & NCE Power Cab Via USB
¿ªÔÆÌåÓýTom,
This is the expected reply from the NCE USB and indicates all is well with COM ports, JMRI settings, and NCE USB settings. Do not change any COM ports, JMRI settings, or NCE USB settings. If you do, all you'll do is go backwards and I'll be forced to give up trying to help you!
Now JMRI has asked the NCE USB to tell the Power Cab to enter program track mode. This hasn't succeeded. I think you'll find the CAB BUS LED (so marked) beside the RJ socket has come on and stuck on. This indicates that the NCE USB is hung up waiting for a Ping from the Power Cab. This indicates a communications failure between the NCE USB and the Power Cab. This could be due to: 1) Bad wiring connection via wires 3 & 4 of the cables, sockets connecting the Power Cab to the NCE USB. They aren't needed when the Power Cab is the only device plugged in. They are essential once you have a second device (NCE USB or slave throttle). Do a bit of visual checking. 2) Bad/marginal RS485 driver chips on either/both of the Power Cab and NCE USB. 3) The problem described at the following link, possibly combined with (2) above. We are suddenly being overwhelmed by this sort of problem and we are suspecting hardware problems... ?
You tell me what you see and I'll interpret. Normal situation is both off, with brief flashes of both when you ask JMRI to do something.
The NCE USB is locked up (you have to unplug the RJ connector to reset it).See above.
You can rule that out.
I'm going to have to sign off for the night and have a life. If the "experts" get you to change settings (and hence set the whole process back), I'm out of this. Dave in Australia |
|||||
Locked
Re: Help Setting up JMRI & NCE Power Cab Via USB
Tom,
On 11 Feb 2020, at 3:11 PM, Thomas Greis <tomgreis@...> wrote:You're looking the wrong place. That is all good. Wait for the email I'm currently composing. Dave in Australia |