To add to this, the scaling factors will need to be different as well. The TS-890 gives a response between 0000 and 0070 and the 590SG is 0000 to 0030, since it has fewer dots on its meter displays.

Eric

On Mon, 19 Aug 2024 at 19:09, Eric Hidle <eric.hidle@...> wrote:

It looks like there is code in ts890s.cxx that handles reading ALC and SWR as independent functions. If I have some time tomorrow I may see if I can add that code to the TS-590SG module. The commands are almost the same, and so are the responses, so I think it could work - though I have zero understanding on if flrig will do anything with that information to update the meters.

Here's the code from the 890. I've changed the meter numbers to match those in the 590SG firmware (in red). I believe these would work fine for the 590SG as it is using a separate command to retrieve a single-meter response.

What are your thoughts?

Eric

int RIG_TS890S::get_swr(void)
{
int mtr = 0;

cmd = "RM11;";
sendCommand(cmd);
showresp(INFO, ASC, "set SWR meter", cmd, "");

cmd = "RM;";
sendCommand(cmd);
if (wait_char(';', 8, 100, "get SWR", ASC) < 8) return 0;

sscanf(replystr.c_str(), "RM1%d", &mtr);

mtr *= 50;
mtr /= 15;
if (mtr > 100) mtr = 100;

return mtr;
}

int RIG_TS890S::get_alc(void)
{
if (read_alc) {
read_alc = false;
return alc_val;
}

cmd = "RM31;";
sendCommand(cmd);
showresp(INFO, ASC, "set ALC meter", cmd, "");

cmd = "RM;";
sendCommand(cmd);
if (wait_char(';', 8, 100, "get ALC", ASC) < 8) return 0;

sscanf(replystr.c_str(), "RM3%d", &alc_val);

alc_val *= 100;
alc_val /= 15;
if (alc_val > 100) alc_val = 100;

return alc_val;
}

On Mon, 19 Aug 2024 at 13:32, Daniel (AE4ON) via <ae4on.usa=[email protected]> wrote:

FYI, there are some features of the 590SG that are not supported by flrig.? I raised some of these concerns previously, and I believe Dave confirmed that he did not have a 590SG radio to test with, and the flrig?module was based on the earlier 590/590S module that was developed with testing performed by a friend who is now a SK.? As an example, the 590SG supports both shift-width and hi-lo filters for both data and non-data modes.? The earlier models did not support that flexibility. In those releases, data modes were limited to shift-width filters so the filter controls in the flrig UI don't necessarily work properly?for a 590SG depending on your usage.

I downloaded the flrig source code, confirmed that I could compile it and build a local version, and I identified some places where some enhancements could be made, but I haven't had time to implement those changes yet.? Possibly the behavior of the meters is another area where the source code for the 590SG rig module could be enhanced or fixed.

What I have done for those features that I require where the UI does not support the capabilities, is to set up Command buttons to send those command sequences.? So I have created command buttons to switch between shift-width and hi-lo filters and to set the width and the hi-lo cut values.? As soon as I have time, I plan to test some modifications to the 590SG module and will submit those for review, testing, and inclusion in the future release.

There may be another solution to the meters issue. I haven't looked at those previously, but I will add that to the items I will look at when I make those improvements to the module for this rig. Possibly the parsing of the response is something that needs to be done in the rig-specific module.

73 de AE4ON

On Mon, Aug 19, 2024 at 10:37?AM Eric Hidle via <eric.hidle=[email protected]> wrote:

Looking at ts590sg.cxx in the source, there do not appear to be any functions here that would read the meters via an RM; command, so I guess we just don't have that functionality for our radio. Perhaps it can be added at some point.

Maybe it's tricky because the radio responds to an RM; with a string that contains responses for all three meters:

RM10000;RM20000;RM30000;

Which are the SWR, COMP, and ALC meters, respectively, in the unit of "number of dots on the display," which then must be converted to a value for each meter.