Re: New patches for XEphem
|
On Tue, Oct 5, 2021 at 9:00 PM Lutz M?ndle < lmaendle@...> wrote: Hi,
here comes some patches to restore and extend functionality of XEphem. ¡
Wow! Thank you for all of these patches, Lutz. I think I should be able to apply them and commit each of them by hand for you with something like:
¡ª to make sure you get proper credit. So unless Mathias needs pull requests created for a reason of his own, or the wider XEphem community's own (in which case I'll be happy to hear more about his reasoning: maybe there are several of these he wants to discuss before they are applied, since they affect things like file download size?), you needn't create any pull requests on GitHub just for my sake; patches are just fine and are easy to apply!
The only question I think I myself have is about the SSL patch. Currently, XEphem compiles and runs just fine under all Ubuntu going back to 14.04. With this new SSL patch, though, it breaks on all but the most recent because it requires OpenSSL 1.1 or later, which it looks was released in September 2018. That would also presumably break it on versions of macOS more than about two or three years old?
Could you adjust the logic to conditionally use the old SSL setup call on systems that don't have the new?TLS_client_method() call? Then we could continue supporting folks without the very most recent operating systems or libraries.
|
