Re: [PATCH v3 2/6] treewide: bcb: move ab_select command to bcb subcommands
|
Hi Dmitry,
toggle quoted message
Show quoted text
On mer., oct. 16, 2024 at 18:48, Dmitry Rokosov <ddrokosov@...> wrote: [...] ``` Long help should use U_BOOT_LONGHELP, we normally handle this with
#ifdef - see cmd/bootflow.c for example
Thank you for pointing me to U_BOOT_LONGHELP. I have redesigned
cmd/bcb.c to utilize the U_BOOT_LONGHELP(), U_BOOT_CMD_WITH_SUBCMDS(),
and U_BOOT_SUBCMD_MKENT() functions. As a result, a significant amount
of command management code has been removed from cmd/bcb.c, making it
look much more compact.
To be honest, I think I missed the minargs parameter in
U_BOOT_CMD_WITH_SUBCMDS(). Including minargs would enable us to avoid
checking argc for a minimum value in the each subcmd callback and
returning CMD_RET_USAGE in case of any errors.
Anyway, I will prepare v5 version with refactored cmd/bcb.c to
U_BOOT_LONGHELP usage.
Thank you for your patience with all the back and forth on this. Looking forward to v5 ! Cheers Mattijs
--
Thank you,
Dmitry
|
