开云体育

I am neither a noob nor a luddite, nor am I a programmer, but I do really like this philosophy! Thank you!

73

-Jim
NU0C

On Thu, 08 Oct 2020 12:02:10 -0700
"OneOfEleven" <cmoss296@...> wrote:

Adding settings for the user to have to set complicates things (decimal point and field char) for them, their are often far better ways really (though not always), you can auto-detect what the file is using (by doing a quick scan of the lines in the file for one), but at the moment I've gone the easy route and set the CSV load/save functions to use the users machine locale setting.

I will ALWAYS avoid adding any unnecessary settings for the user to have to set/fill-in if at all possible as it gives them something else to set/get wrong and cause problems.

Never let your PC software generate exception pop-up boxes on a users PC, if it does (as your CSV code was doing with the range check error exception dialogs) then the code must be fixed to never do so (you can totally screw up a PC if it gets out of hand if your software decides to throw up a 100 exception boxes in the following 2 seconds - I've had that happen and learn from it). Always assume the user is going to load a totally incompatible file (because they will at some point), always do sanity checks on every part of the data you're loading in, if their seems to be a problem with the data then let the user know so that they can either fix the error they are making or get back to you with the much needed feedback for you to fix the source coding error - treat pop-up exception dialogs as evil ;)

If excel is any good it should, no guarantee though, have to try it and see.

Using double quotes around each param is quite normal in CSV files (to over come the decimal point ambiguity).

The intention is to load the .csv file into excel for further analysis
Will this work with double quotes?

I've just set the CSV save function to surround each parameter (value) in the CSV file with double quotes (the CSV load function removes them) - this solves the decimal point problem.

Adding settings for the user to have to set complicates things (decimal point and field char) for them, their are often far better ways really (though not always), you can auto-detect what the file is using (by doing a quick scan of the lines in the file for one), but at the moment I've gone the easy route and set the CSV load/save functions to use the users machine locale setting.

I will ALWAYS avoid adding any unnecessary settings for the user to have to set/fill-in if at all possible as it gives them something else to set/get wrong and cause problems.

Never let your PC software generate exception pop-up boxes on a users PC, if it does (as your CSV code was doing with the range check error exception dialogs) then the code must be fixed to never do so (you can totally screw up a PC if it gets out of hand if your software decides to throw up a 100 exception boxes in the following 2 seconds - I've had that happen and learn from it). Always assume the user is going to load a totally incompatible file (because they will at some point), always do sanity checks on every part of the data you're loading in, if their seems to be a problem with the data then let the user know so that they can either fix the error they are making or get back to you with the much needed feedback for you to fix the source coding error - treat pop-up exception dialogs as evil ;)

I sometimes cut some corners in my self inflicted urgency...
While you are making changes, can I kindly ask you to make the "S11" and "S21" part of the displayed graph names coming from a #define or a setting variable so I can change "S11" to "Level" in one location so Graphs.cpp can be reused without any change??

Had a quick look through your CSV code and found source code problems that will cause range check error pop ups.

I'll create a new function purely for .CSV file loading/saving and fix the source coding problems at the same time later on.

On Thu, Oct 8, 2020 at 12:53 AM, OneOfEleven wrote:

No idea where the github line endings settings is, I just use GitHub Desktop to push any file changes.

If you add a file named .gitattributes to the folder where the nanoVNA-App .git subfolder and all the working sources are located, with only one line in it with:
* text=auto
the line endings should become normalized and the problems will disappear over time
Some of you current source files have a mix of windows line endings and linux line endings.
Examples:?
Graphs.cpp
Unit1.cpp
and my merging normalizes everything to windows line endings which confuses github compare and merg meaning I have to do all updating manually


I pushed my branch containing the tinySA variant.

If you search for field_sep, decimal_dot, fieldSep and decimalDot you will quickly find what I did to the regionalization of the .csv files

On Wed, Oct 7, 2020 at 09:05 AM, Michael Graves wrote:

On the touch calibration screen, you may want to put little plus signs '+' or cross hairs with a dot in the center.?

An excellent idea!? I often have to go through the calibration procedure more than once before I get it right.

On Thu, Oct 8, 2020 at 08:28 AM, Erik Kaashoek wrote:

If OK with you I will push my branch to you so you can easily see the changes I made
Would it be possible for you to enable normalization of line endings in your github repository?
Windows is driving me crazy.......

Yes sure.

No idea where the github line endings settings is, I just use GitHub Desktop to push any file changes.

On Wed, Oct 7, 2020 at 04:52 AM, Bill Cromwell wrote:

I have been reluctant to install any of the "upgrades". I can now afford to risk one of the tinySA units to try installing the "new, improved, giant economy size" software. I am not using PC software for these yet and may decide to not use it. I will not have Windows in my home - actually my computer. So updates to exe files have no appeal unless they will run under WINE.

Never had any problems updating my tinySAs or my NanoVNAs.? Go ahead and do it.? My Windows policy is very similar to yours.

On Wed, Oct 7, 2020 at 05:41 AM, Erik Kaashoek wrote:

c:\work\DFU\dfu-util? -a 0 -s 0x08000000:leave -D c:\work\VNA\tinySA\build\tinySA.bin
under linux this should be something similar

jim@jimT450:~$ sudo dfu-util? -a 0 -s 0x08000000:leave -D tinySA_v1.0-52-g1167bde.bin

If OK with you I will push my branch to you so you can easily see the changes I made
Would it be possible for you to enable normalization of line endings in your github repository?
Windows is driving me crazy.......

On Thu, Oct 8, 2020 at 01:34 AM, EB4APL wrote:

PD. Maybe Cathy could do the same in the nanoVNA-App for writing its
files. It is really useful for countries which use comma as decimal
separator.

Yes no problem. Though I don't know what's been done or anything, Erik would have to let me see the source code to see what he's done exactly.

Hi Erik,

The version is really 1.240.5.

A quick test shows that you nailed the problem when writing CSV files. The function to choose the decimal and field separators runs perfectly. This makes very easy to use these files in Excel when Windows uses this configuration. Without it, it is quite cumbersome to do the conversion.

Thank you again.

Ignacio EB4APL

PD. Maybe Cathy could do the same in the nanoVNA-App for writing its files. It is really useful for countries which use comma as decimal separator.

--
El software de antivirus Avast ha analizado este correo electrónico en busca de virus.

New tinySA-App release
Version 1.240.4
Changes:
- Integrated the normalize function from OneOfEleven
- Solved a crash in writing the CSV files when localization set to using a "," as decimal dot.

Erik, might I make a suggestion.? On the touch calibration screen, you may want to put little plus signs '+' or cross hairs with a dot in the center.? This way people will try harder to touch that little dot.? I think this will make it clearer for people to know exactly where to touch.
--
73, Michael, KE4EST

On Wed, Oct 7, 2020 at 06:58 AM, n2msqrp wrote:

How can I properly execute the TOUCH CAL and TOUCH TEST? How do I SAVE it? Would you have a video sowing this procedure?

Here it is:?https://www.youtube.com/watch?v=LghlQ_aWjAs

I think I know what is causing the crash. Wait for the next release