¿ªÔÆÌåÓý

ctrl + shift + ? for shortcuts
© 2025 Groups.io

[PATCH v2 0/3] Meson: R/W support for pages used by boot ROM


Arseniy Krasnov
 

Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be accessed
> in special mode ("short" ECC + scrambling). In practice this feature is
> needed when we want to update first block of NAND - driver will enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)

--
2.30.1


 

On 23/08/2024 10:29, Arseniy Krasnov wrote:
Hi! Got it, thanks!
On 23.08.2024 11:10, Michael Nazzareno Trimarchi wrote:
Hi Arseniy

On Thu, Aug 22, 2024 at 9:04?AM Arseniy Krasnov
<avkrasnov@...> wrote:

Hi, thanks!

Thanks, Arseniy

On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote:
Hi

I will read them tomorrow ;)

Thank you for understanding
All the series are delegated to Neil. I will review anyway but I think
that will then pick from him
Sure I can pick them if reviewed!

Neil


Michael

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


Michael Nazzareno Trimarchi
 

Hi

I will read them tomorrow ;)

Thank you for understanding

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


Michael Nazzareno Trimarchi
 

Hi Arseniy

On Thu, Aug 22, 2024 at 9:04?AM Arseniy Krasnov
<avkrasnov@...> wrote:

Hi, thanks!

Thanks, Arseniy

On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote:
Hi

I will read them tomorrow ;)

Thank you for understanding
All the series are delegated to Neil. I will review anyway but I think
that will then pick from him

Michael

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@...
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@...
www.amarulasolutions.com


Arseniy Krasnov
 

Hi! Got it, thanks!

On 23.08.2024 11:10, Michael Nazzareno Trimarchi wrote:
Hi Arseniy

On Thu, Aug 22, 2024 at 9:04?AM Arseniy Krasnov
<avkrasnov@...> wrote:

Hi, thanks!

Thanks, Arseniy

On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote:
Hi

I will read them tomorrow ;)

Thank you for understanding
All the series are delegated to Neil. I will review anyway but I think
that will then pick from him

Michael

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


Arseniy Krasnov
 

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be accessed
> in special mode ("short" ECC + scrambling). In practice this feature is
> needed when we want to update first block of NAND - driver will enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


Arseniy Krasnov
 

Hi, thanks!

Thanks, Arseniy

On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote:
Hi

I will read them tomorrow ;)

Thank you for understanding

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


Michael Nazzareno Trimarchi
 

Hi Aresenly

On Fri, Aug 23, 2024 at 10:53?AM Neil Armstrong
<neil.armstrong@...> wrote:

On 23/08/2024 10:29, Arseniy Krasnov wrote:
Hi! Got it, thanks!

On 23.08.2024 11:10, Michael Nazzareno Trimarchi wrote:
Hi Arseniy

On Thu, Aug 22, 2024 at 9:04?AM Arseniy Krasnov
<avkrasnov@...> wrote:

Hi, thanks!

Thanks, Arseniy

On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote:
Hi

I will read them tomorrow ;)

Thank you for understanding
All the series are delegated to Neil. I will review anyway but I think
that will then pick from him
Sure I can pick them if reviewed!
Can you please resend the series? I don't find in my mailbox (strange)

Michael

Neil


Michael

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)


--
Michael Nazzareno Trimarchi
Co-Founder & Chief Executive Officer
M. +39 347 913 2170
michael@...
__________________________________

Amarula Solutions BV
Joop Geesinkweg 125, 1114 AB, Amsterdam, NL
T. +31 (0)85 111 9172
info@...
www.amarulasolutions.com


Arseniy Krasnov
 

On 26.08.2024 09:15, Michael Nazzareno Trimarchi wrote:
Hi Aresenly

On Fri, Aug 23, 2024 at 10:53?AM Neil Armstrong
<neil.armstrong@...> wrote:

On 23/08/2024 10:29, Arseniy Krasnov wrote:
Hi! Got it, thanks!

On 23.08.2024 11:10, Michael Nazzareno Trimarchi wrote:
Hi Arseniy

On Thu, Aug 22, 2024 at 9:04?AM Arseniy Krasnov
<avkrasnov@...> wrote:

Hi, thanks!

Thanks, Arseniy

On 22.08.2024 00:17, Michael Nazzareno Trimarchi wrote:
Hi

I will read them tomorrow ;)

Thank you for understanding
All the series are delegated to Neil. I will review anyway but I think
that will then pick from him
Sure I can pick them if reviewed!
Can you please resend the series? I don't find in my mailbox (strange)
Hi, sure, done. With 'RESEND' prefix.

Thanks


Michael

Neil


Michael

Michael

Il mer 21 ago 2024, 22:25 Arseniy Krasnov <avkrasnov@...> ha
scritto:

Hi, sorry, pls ping ?

Thanks

On 08.07.2024 10:13, Arseniy Krasnov wrote:
Patchset is based on patchset for Linux (today merged to nand-next):


Here is description from it:

> Amlogic's boot ROM code needs that some pages on NAND must be written
> in special "short" ECC mode with scrambling enabled. Such pages:
> 1) Contain some metadata about hardware.
> 2) Located with some interval starting from 0 offset, until some
> specified offset. Interval and second offset are set in the
> device tree.
>
> This patchset adds R/W support for such pages. To enable it we can
setup
> it in dts:
>
> nand-is-boot-medium;
> amlogic,boot-pages = <1024>;
> amlogic,boot-page-step = <128>;
>
> It means that each 128th page in range 0 to 1024 pages will be
accessed
> in special mode ("short" ECC + scrambling). In practice this feature
is
> needed when we want to update first block of NAND - driver will
enable
> required mode by itself using value from device tree.

The only difference is that patchset for Linux updates DT bindings, while
this adds NAND_IS_BOOT_MEDIUM flag support.

Changelog:
v1 -> v2:
* Pls see per-patch changelog.

Arseniy Krasnov (3):
mtd: rawnand: nand_base: support for 'NAND_IS_BOOT_MEDIUM' flag
mtd: rawnand: meson: refactor use of 'meson_nfc_cmd_access()'
mtd: rawnand: meson: read/write access for boot ROM pages

drivers/mtd/nand/raw/meson_nand.c | 84 +++++++++++++++++++++----------
drivers/mtd/nand/raw/nand_base.c | 3 ++
include/linux/mtd/rawnand.h | 5 ++
3 files changed, 65 insertions(+), 27 deletions(-)