first impression: it's sharpened up a lot recently.
- Preface
"(You'll have to work on grumpiness...)" - should be separate bullet
point
"4WD" -> "4 wheel drive" (for those with english as a second language)
"hoohaw" -> hooha (from the Yiddish)
I suspect it was my comment that prompted the note about the style. If
you're going to do it, don't apologize, it's the house style anyway. If
you want to give the feel of two people talking ("Schizophrenic? Us?"),
how about putting some of the asides in another font to make the point?
You could play it like Jimminy Cricket (cf. Pinocchio).
- Example: Money
Money.equals(), why the parentheses around currency.equals() ?
- This time for sure
By leaving out the second parameter (for now), you're concentrating just
on how the pieces fit together -- how the code "flows". Once that's
stabilised, you can add more detail.
Exchange.addRate() - if it doesn't do anything, leave it out. You can
add it when you're ready to use it. In the meantime, you could have an
instance variable that you initialise to 2, or how about adding it to
the constructor if you want to make it visible?
exchange = new Exchange(2);
Don't forget, strings should be compared with .equals(), not ==
for example "GBP".equals(currency)
Guess you don't like conditional expressions:
return ("GBP".equals(currency) ? 2 : 1);
The one advantage they have is that they make it clear that you're
returning a single value.
Enough for now.
S.
