开云体育

Folks,
There appear to be two locations on GitHub for the nanoVNA firmware:
original:
hugen:

Both appear to be old and haven't been updated in some time.

It would be great if Hugen would provide a URL link to the opensource code he is currently maintaining for this device or at least make some commits to the repository.

Thanks,
Larry

I'm sorry Larry.
Under the GNU protocol, I should open my code, but there are clone makers who use my firmware and claim to have modified the code themselves, and I delayed the plan to open the code in order to avoid worse.

hugen

Okay, but isn't that what GitHub is for?
These days with all the fancy dissassemblers available, it's very easy to reverse engineer most code anyways and it is an unfortunate fact that everything of value is copied at some point.
So, without going into great detail, are you able to say what differences are between the original NanoVNA F/W and your version? (Fixes and/or changes).

Thanks
Larry

I am curious if there is a rough plan/time line for you to open your firmware? I just got mine in the mail today and am loving it thank you for helping make an awesome tool for us! Definitely could see my self trying to get some pull requests sent as well with this just to add some QOL features if need be. Coming from an AGILENT 5230N PNA-L this feels like home already!

On Mon, 8 Jul 2019 at 02:21, <hugen@...> wrote:

I'm sorry Larry.
Under the GNU protocol, I should open my code, but there are clone makers
who use my firmware and claim to have modified the code themselves, and I
delayed the plan to open the code in order to avoid worse.

hugen

If you used GPL code to create your own, then you are breaking both the
spirit and legality of the GPL to keep the source code closed. I find that
a deplorable thing to do.

Yes, I know that the Chinese counterfeits can be annoying, but that doesn’t
change the GPL license conditions.

Dave.


--
Dr. David Kirkby,

On Mon, 8 Jul 2019 at 02:39, Larry Rothman <ac293@...> wrote:

Okay, but isn't that what GitHub is for?
These days with all the fancy dissassemblers available, it's very easy to
reverse engineer most code anyways and it is an unfortunate fact that
everything of value is copied at some point.
So, without going into great detail, are you able to say what differences
are between the original NanoVNA F/W and your version? (Fixes and/or
changes).

Thanks
Larry

Larry,
Why should hugen not go into great detail? His actions are a blatant
contravention of the GPL license.

Dave
--
Dr. David Kirkby,

On Sat, Jul 20, 2019 at 10:10 PM, Dr. David Kirkby from Kirkby Microwave Ltd wrote:

On Mon, 8 Jul 2019 at 02:39, Larry Rothman <ac293@...> wrote:

Okay, but isn't that what GitHub is for?
These days with all the fancy dissassemblers available, it's very easy to
reverse engineer most code anyways and it is an unfortunate fact that
everything of value is copied at some point.
So, without going into great detail, are you able to say what differences
are between the original NanoVNA F/W and your version? (Fixes and/or
changes).

Thanks
Larry

Larry,
Why should hugen not go into great detail? His actions are a blatant
contravention of the GPL license.

Dave
--
Dr. David Kirkby,

Dr Kirkby is absolutely right, GPL is GPL and that's that.

In general terms, the GPL only requires that source is made available along
with the binary. It doesn't need to be put in a github repo. It doesn't
require that anything is given for free.

So someone who purchased from hugen can request the source be provided. He
must then provide it to them - for a reasonable fee if he chooses to charge
for it.

The common method is to publish it on the www in github, but that is not a
requirement of the GPL.


On Sun, 21 Jul 2019 at 18:56, Hans J Albertsson <hans.j.albertsson@...>
wrote:

On Sat, Jul 20, 2019 at 10:10 PM, Dr. David Kirkby from Kirkby Microwave
Ltd wrote:

On Mon, 8 Jul 2019 at 02:39, Larry Rothman <ac293@...> wrote:

Okay, but isn't that what GitHub is for?
These days with all the fancy dissassemblers available, it's very easy

to

reverse engineer most code anyways and it is an unfortunate fact that
everything of value is copied at some point.
So, without going into great detail, are you able to say what

differences

are between the original NanoVNA F/W and your version? (Fixes and/or
changes).

Thanks
Larry

Larry,
Why should hugen not go into great detail? His actions are a blatant
contravention of the GPL license.

Dave
--
Dr. David Kirkby,

Dr Kirkby is absolutely right, GPL is GPL and that's that.

I share my changes on the forum() and provide the original code to users who have purchased my hardware. But a bad clone appeared and claimed to have made improvements by themselves. To avoid getting worse, I had to temporarily stop sharing the modified code. Rest assured that as long as things don't get any worse, I'll share my changes again a year later.

On Sun, 21 Jul 2019 at 11:10, <hugen@...> wrote:

I share my changes on the forum(
) and provide the original
code to users who have purchased my hardware. But a bad clone appeared and
claimed to have made improvements by themselves. To avoid getting worse, I
had to temporarily stop sharing the modified code. Rest assured that as
long as things don't get any worse, I'll share my changes again a year
later.

Let’s hope one of the people that purchased hardware from you make the code
public. Under the terms of the GPL you have to make then aware that they
can do that, and if you try to restrict them, you are breaking the terms of
the GPL.

You should not be temporarily stopping the sharing of code. That’s against
the GPL.

EVERY TIME YOU SELL A PRODUCT YOU SHOULD GIVE TELL THEM THE CODE IS GPL
LICENSED AND HOW THEY CAN GET A COPY.

*I personally find your actions deplorable. *You have taken code provided
freely by others under a GPL license, then are not following the license
conditions.

Dave.

--

Dr. David Kirkby,

I've reshared the code.

On Fri, 26 Jul 2019 at 09:12, <hugen@...> wrote:

I've reshared the code.

Thank you. That is useful and now perhaps we can improve upon it.

I rather suspect that I have one of yours, as it has the shielding. (I had
to remove the battery with a far from suitable soldering iron as the first
one didn’t work and a replacement was shipped by express mail, but
apparently they were unable to ship the battery that way. )Anyway, I have a
working one.

I would suggest that you consider making one with a larger screen and
better quality parts. I think people will pay more for a better quality
product. The screen size in particular seems very small.

Dave

--

Dr. David Kirkby,

Hi hugen!, in what operating system, and what software to do compilation of the code? If possible, describe which version of Chibios. Thank!

Thank you!

You can compile with gcc-arm-none-eabi 4 or 5 under linux or macos.
Before compilation you need to copy the chibios directory from the original project of edy555.

Hi Hugen,
01:12 Fri 26 Jul 19 , hugen@... wrote:

I've reshared the code.

I've recompiled and tested it but it hangs on startup. I've found the
problem in internal adc calibration; commenting out that part of code, i.e.:

void adc_init(void)
{
rccEnableADC1(FALSE);

/* Calibration procedure.*/
/* ADC->CCR = 0; */
/* ADC1->CR |= ADC_CR_ADCAL; */
/* while (ADC1->CR & ADC_CR_ADCAL) */
/* ; */

ADC1->CR = ADC_CR_ADEN;
while (!(ADC1->ISR & ADC_ISR_ADRDY))
;
}

It do the job and nanovna works, fine to me at a first test.

Internal adc is used for touch screen readings, right? So if it isn't
calibrated it should have problems in touch-screen to display allignment,
right? But it doesn't happen to me or it's very small.

So, could you explain me why this adc calibration problem?

I've also notice that after fw update one has to power off the nanovna and
wait until blue led is off and than power on again and issue a new
calibration, otherwise it's impossible to calibrate correctly
(i.e. after a complete calibration measuring tha same open used for
calibration gives ~-8.5dB of return loss...).

Many thanks, I'm going to work on the code!

Lapo, IK5NAX

Huge
The "Reference" links at the bottom of the GitHub page don't work.

Joe

Use the ones I posted several posts back.
Use Google translate on them.

Here are the links from the PDF I posted...

All references to the NanoVNA on TTRFTECH:


These pages have excellent original design notes from edy555!!!
Use Google to translate from Japanese to your native language.

Hi to all! I ask for help, is it possible to compile the source code in the Windows 10 OS?

You may have pressed the touch screen while adc is initializing.
It might be better to add a wait.

void adc_init(void)
{
rccEnableADC1(FALSE);

/* Calibration procedure.*/
ADC->CCR = 0;
while (ADC1->CR & ADC_CR_ADEN)
;
ADC1->CR |= ADC_CR_ADCAL;
while (ADC1->CR & ADC_CR_ADCAL)
;

ADC1->CR = ADC_CR_ADEN;
while (!(ADC1->ISR & ADC_ISR_ADRDY))
;
}





On Sat, Jul 27, 2019 at 04:45 AM, Lapo Pieri wrote:

Hi Hugen,
01:12 Fri 26 Jul 19 , hugen@... wrote:

I've reshared the code.

I've recompiled and tested it but it hangs on startup. I've found the
problem in internal adc calibration; commenting out that part of code, i.e.:

void adc_init(void)
{
rccEnableADC1(FALSE);

/* Calibration procedure.*/
/* ADC->CCR = 0; */
/* ADC1->CR |= ADC_CR_ADCAL; */
/* while (ADC1->CR & ADC_CR_ADCAL) */
/* ; */

ADC1->CR = ADC_CR_ADEN;
while (!(ADC1->ISR & ADC_ISR_ADRDY))
;
}

It do the job and nanovna works, fine to me at a first test.

Internal adc is used for touch screen readings, right? So if it isn't
calibrated it should have problems in touch-screen to display allignment,
right? But it doesn't happen to me or it's very small.

So, could you explain me why this adc calibration problem?

I've also notice that after fw update one has to power off the nanovna and
wait until blue led is off and than power on again and issue a new
calibration, otherwise it's impossible to calibrate correctly
(i.e. after a complete calibration measuring tha same open used for
calibration gives ~-8.5dB of return loss...).

Many thanks, I'm going to work on the code!

Lapo, IK5NAX

On Sat, Jul 27, 2019 at 04:45 AM, Lapo Pieri wrote:

It do the job and nanovna works, fine to me at a first test.

Internal adc is used for touch screen readings, right? So if it isn't
calibrated it should have problems in touch-screen to display allignment,
right? But it doesn't happen to me or it's very small.

So, could you explain me why this adc calibration problem?

I've also notice that after fw update one has to power off the nanovna and
wait until blue led is off and than power on again and issue a new
calibration, otherwise it's impossible to calibrate correctly
(i.e. after a complete calibration measuring tha same open used for
calibration gives ~-8.5dB of return loss...).