One way to apply some recent important code changes #sBitx
|
Hi,
I wrote the attached shell script that puts the current afarhan github code base into its own new folder then "cherry picks" some recent changes primarily by Steve Beckman N3SB that I think make the code work a lot better. As usual, no guarantee / warranty is implied or granted, etc. If you don't know what a shell script is, you probably shouldn't run one. If you do know what a shell script is, I recommend you read this one before you run it and make sure I didn't do anything stupid. If you do run it, please let me know if I did anything stupid. If you change the script without knowing how shell scripts work, well, it isn't me being stupid, is it? Yet I think it shows that it is relatively easy to apply the changes that are already waiting in github ready to be merged. -- Regards, Dave, N1AI |
|
Steve,
Yes, the IF auto gain is most noticeable as it works. I installed it twice. First to v3.0 and then to v3.01. For the latter, in the case of sbitx.c, #71 was enough because the content of #70 is included. Ashar, I think it's worth drawing Ashar's attention to the fact that new owners, if they start with v3.01, want to save QSOs twice in the log file. I got around it by creating sbitx.db with 3.0 and then moving it to v3.01. -- Gyula HA3HZ |
|
On Wed, Jan 10, 2024 at 06:15 PM, Jeff Duce wrote:
This looks great, but since it's been 20+ years since I was using linux regularly, just to make sure I know what I'm doing:? I'm assuming that I'm going to copy this file to the sbitx, chmod it, and then just run it. Anything else??No, that is fine. It looks like it will save my existing log book, but just wanted to double check with you that it does.? I'll probably back it up anyway, just in case.The script will create a new folder/directory for everything it does, it will make new copies of everything in your sbitx/data directory including your log book. Currently that new folder is $HOME/sbitx-0210 . If the code in that folder works better than the stuff in $HOME/sbitx, you can just rename $HOME/sbitx to something else and rename $HOME/sbitx-0210 to $HOME/sbitx. I'm working on fixing the agc merge issue so soon there will be a new version of the script and it will create $HOME/sbitx-0211. ? -- Regards, Dave, N1AI |
|
On Wed, Jan 10, 2024 at 06:39 PM, Steve Beckman wrote:
Dave - thanks for developing this script - it'll make it easier for others to try the fixes. I didn't try running the script - I already have these fixes incorporated into my code. Not sure why the Auto IF Gain mod isn't merging properly - I'll give it a look in a bit. That's one of my favorite features now.I understand the conflict and am working on the best way to resolve it.? My code is the source of the conflict.? Hopefully I will have it all sorted by end of day today and issue an updated script, but now I have other things to do for the next few hours. Hope Farhan is able to evaluate the proposed changes and pull them into the main branch soon - so that the documented "./update" command can be used by any sBitx owner to get the fixes. Some of the bugs that were addressed could drive sBitx owners to post negative reviews, which would be a shame since the fixes are right there to be incorporated.I agree.? It is important to get the best improvements we can get in a short amount of time.? Time passes each and every day, and as the saying goes, you never get a second chance to make a first impression.?? ? -- Regards, Dave, N1AI |
|
On Thu, Jan 11, 2024 at 02:18 PM, Dave, N1AI wrote:
The script will create a new folder/directory for everything it does, it will make new copies of everything in your sbitx/data directory including your log book.I have noticed something: the idiom the sbitx code uses to find data ALWAYS LOOKS IN $HOME/sbitx/data and not in the current directory... Currently that new folder is $HOME/sbitx-0210 .This is all true, but the run time code?ALWAYS LOOKS IN $HOME/sbitx/data and not in the current directory. ? This means that the copy of the data folder I'm making in $HOME/sbitx-0211 is a snapshot of the past and not going to be used by the code in $HOME/sbitx-0211. Yet it still is a snapshot of the data folder as it was when the script was run, which is IMO a helpful backup. You just have to realize that if you make changes, they need to be made in $HOME/sbitx/data and not in the backup copies. On Wed, Jan 10, 2024 at 03:41 PM, Dave, N1AI wrote: I wrote the attached shell script that puts the current afarhan github code base into its own new folder then "cherry picks" some recent changes primarily by Steve Beckman N3SB that I think make the code work a lot better.All of this still applies, especially the parts in bold. So, with these statements emphasized, the updated script that also includes the AGC merge is attached. Those who ran the first script will have the code without AGC in $HOME/sbitx-0210 and with AGC (and a few other minor things) in $HOME/sbitx-0211. On Thu, Jan 11, 2024 at 02:26 PM, Dave, N1AI wrote: I agree.? It is important to get the best improvements we can get in a short amount of time.? Time passes each and every day, and as the saying goes, you never get a second chance to make a first impression.??Still true. ? -- Regards, Dave, N1AI |
|
I'll look into it later.
There are changes related to the handling of straight keys in CW mode. I think the PTT line is shared between the mic jack and the key jack? Maybe somehow the CW changes are interacting with voice mode too. If you want to explore a bit, just look for the straight key part of the script: Put a '#' at the start of lines 50-52 and that fix won't be applied. Re-run the script after, it will erase the current $HOME/sbitx-0211 with a new version so keep any stuff you need from there! If the problem goes away, you have confirmed the problem is in that area. FWIW I use CW a lot and voice almost never! -- Regards, Dave, N1AI |
|
On Fri, Jan 12, 2024 at 03:57 PM, Dave, N1AI wrote:
Put a '#' at the start of lines 50-52 and that fix won't be applied.I have done this and can confirm removing these lines restores proper mic operation. Looks like the fix needs to be improved. Thanks for reporting this problem! Yep, I had to go dig out the mic from my POTA backpack! ? -- Regards, Dave, N1AI |
|
The attached sb-cherries-v3.sh script brings in all the fixes except the straight key one.
It puts the new sbitx code and backup of data into $HOME/sbitx-0212. Please confirm the mic operates as before. I'm going to close the straight key PR till I get time to look at the code some more, which is not tonight. -- Regards, Dave, N1AI |
|
On Sat, Jan 13, 2024 at 03:43 PM, Joel Caulkins/N6ALT wrote:
I ran sb-cherries-v3.sh and launched sbitx, the PTT is now working, thanks and I look forward to more improvements.Thanks again for your bug report earlier!? ?I'm glad it's working now! On Sat, Jan 13, 2024 at 06:32 PM, Steve Beckman wrote: Dave - your update script worked great on my DE. Thanks!Thanks for the significant changes you made to improve the software! On Fri, Jan 12, 2024 at 03:57 PM, Dave, N1AI wrote: I think the PTT line is shared between the mic jack and the key jack?I learned that it is.? This means you really can't have independent logic for CW vs Voice. This means my desire to use a mono plug for CW just won't work. The instant I plug in a mono plug the PTT for both CW and Voice are asserted.? Given the line is shared, there's no way for the software to treat CW and Voice independently. In theory I could wire up an independent GPIO for each but then I have my own unique configuration. In the real world it's easier to wire up a stereo plug with ring floating for the straight key. So, there's no pressing need for a new "cherry picking" script till the next interesting set of changes are developed.? -- Regards, Dave, N1AI |
|
On Mon, Jan 15, 2024 at 11:12 AM, Rafael Diniz wrote:
How about the DASH signal (RPi pin 29) ?? I think it was supposed to be used by something, but I'm not sure how, as I never really understood how to trigger it.In?/g/BITX20/topic/99964842#107960?I show DASH really should be called DOT since it is the signal coming from the tip of the CW jack. But when in CW mode, when PTT is down, how the software does not know if it is voice or CW?The software does, but I concluded my ultimate goal was futile.? I wanted to use a mono plug for my CW jack, yet if you plug in a mono plug you short RING to ground, and since both PTTs are wired together, you assert PTT for both voice and CW mode.? This means when you do switch to voice mode (either intentionally or by clicking through the mode selections) you go key-down in voice mode just because a straight key is plugged in, which IMO is not acceptable.? ?Better to do what I say in that thread, either rewire using a stereo jack or buy an adapter that separates tip and ring.? Please let me know if I am missing something, but that's my conclusion so far.?? Note the manual says the same PTT is used for voice and key jacks and you can put a straight key in the voice jack.? I suppose this would be a neat feature if you want both straight key and paddles and no external microphone, a true CW person if I ever saw one.? Actually the full kit has an internal mic inside the radio so you could use the straight key to assert PTT and still use voice mode with straight key and paddles plugged in!? So I guess it is not an uninformed choice, it's just not what I expected based on what other radios in my shack do. ? -- Regards, Dave, N1AI |
Dave, N1AI
Bob Benedict, KD8CGH
HA3HZ
Joel Caulkins/N6ALT